Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(python): cannot call a method that takes an empty struct #3372

Merged
merged 1 commit into from
Feb 8, 2022

Conversation

RomainMuller
Copy link
Contributor

Empty dictionaries are false-y in Python, so the test that checked for
structs via the existence of a property mapping table was incorrect, as
it only checked truthiness of the mapping, instead of checking for it
being non-None.

Fixes #2846


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Empty dictionaries are false-y in Python, so the test that checked for
structs via the existence of a property mapping table was incorrect, as
it only checked truthiness of the mapping, instead of checking for it
being non-`None`.

Fixes #2846
@RomainMuller RomainMuller requested a review from a team February 8, 2022 12:56
@RomainMuller RomainMuller self-assigned this Feb 8, 2022
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Feb 8, 2022
@mergify
Copy link
Contributor

mergify bot commented Feb 8, 2022

Thank you for contributing! ❤️ I will now look into making sure the PR is up-to-date, then proceed to try and merge it!

@mergify mergify bot added the pr/ready-to-merge This PR is ready to be merged. label Feb 8, 2022
@mergify
Copy link
Contributor

mergify bot commented Feb 8, 2022

Merging (with squash)...

@mergify mergify bot merged commit c36b67c into main Feb 8, 2022
@mergify mergify bot deleted the rmuller/fix-empty-struct-param branch February 8, 2022 18:28
@mergify mergify bot removed the pr/ready-to-merge This PR is ready to be merged. label Feb 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot call a method that takes an empty struct from Python
2 participants